Add max attempt on URL generation #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
championswimmer
requested changes
Feb 4, 2024
onepixel.production.env
Outdated
| MAIN_SITE_HOST=1px.li | ||
| URL_GEN_MAX_RETRIES=1000 |
There was a problem hiding this comment.
production retries should not be 1000 either, 10 is a better limit
commenting below, why the error message is not good
src/controllers/urls.go
Outdated
| @@ -53,6 +54,10 @@ var ( | |||
| status: fiber.ErrForbidden.Code, | |||
| message: "this shortURL is not allowed to be created", | |||
| } | |||
| MaxRetriesReachedError = &UrlError{ | |||
| status: fiber.ErrInternalServerError.Code, | |||
| message: "max number of attempts to generate a URL reached. Please try after some time", | |||
There was a problem hiding this comment.
so this is not a good error to give the client, because the client is technically not "retrying" these many times. It is our code's internal recursion causing it.
A 508 StatusLoopDetected error with message "server exhausted attempts to generate a unique shortUrl, please try again" would be better
There was a problem hiding this comment.
Thanks for the suggestion. Have updated the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a limit on the maximum number of retries in case of collisions.
Closes Issue #50