Add Login API #19
Open
Add Login API #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added JWT login auth API and middleware to restrict authenticated routes. Added ErrorResponse struct to return during caught errors Added a recovery middleware to recover from panics
|
I have assumed getting user by ID is a public API and updating the user will be a private API here. |
championswimmer
requested changes
Nov 5, 2023
src/routes/api/users.go
Outdated
| router.Post("/", registerUser) | ||
| router.Post("/login", loginUser) | ||
| router.Get("/:id", auth.MandatoryAuthMiddleware, getUserInfo) | ||
| router.Get("/:id", getUserInfo) |
There was a problem hiding this comment.
the get path should also be private here
anascann
reviewed
Nov 8, 2023
Comment on lines
+50
to
+53
| res := c.db.First(user) | ||
| if res.Error != nil { | ||
| return nil, res.Error | ||
| } |
There was a problem hiding this comment.
Suggested change
| res := c.db.First(user) | |
| if res.Error != nil { | |
| return nil, res.Error | |
| } | |
| if res := c.db.First(user); res.Error!=nil{ | |
| return nil, res.Error | |
| } | |
You can have one liner error return statements. just a suggestion ;) looks neat and cute!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added JWT login auth API and middleware to restrict authenticated routes.
Added ErrorResponse struct to return during caught errors
Added a recovery middleware to recover from panics
fixes #13