Add conflict to cosign_sign #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonjohnsonjr
force-pushed
the
sign-conflict
branch
3 times, most recently
from
baad44d to
8e32644
Compare
jonjohnsonjr
force-pushed
the
sign-conflict
branch
3 times, most recently
from
d0e1a77 to
3a97b59
Compare
The default is APPEND, which matches the current behavior today. This adds both REPLACE and SKIPSAME to match what cosign_attest does. Instead of using predicateType as the replacement criteria, this uses the signature layer's digest. It should be safe to bump this before we bump terraform-publisher-apko because the default matches the current behavior. Signed-off-by: Jon Johnson <[email protected]>
jonjohnsonjr
force-pushed
the
sign-conflict
branch
from
3a97b59 to
bb11eec
Compare
imjasonh
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default is APPEND, which matches the current behavior today. This adds both REPLACE and SKIPSAME to match what cosign_attest does. Instead of using predicateType as the replacement criteria, this uses the signature layer's digest.
It should be safe to bump this before we bump terraform-publisher-apko because the default matches the current behavior.