Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Images Overview + adding Wolfi package context #1482

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

SharpRake
Copy link
Collaborator

Type of change

This PR updates the Images Overview doc to add more information about the product. Specifically, it highlights the value of minimal Images, explains the high level differences between Developer and Production Images, and adds more Academy links to the overview doc.

What should this PR do?

Resolves https://github.com/chainguard-dev/internal/issues/3621
Resolves https://github.com/chainguard-dev/internal/issues/3602

Why are we making this change?

Adding wolfi package context to final places unless suggested otherwise. First major update (aside from one Erika drafted last week) to this doc since it was first published in 2022.

What are the acceptance criteria?

How do the changes fit? Does it tell too much? I tried to explain things without getting too far into the weeds or getting too far away from the Images themselves.

How should this PR be tested?

No changes involve technical procedures, shouldn't require a tech test.

@SharpRake SharpRake added documentation Improvements or additions to documentation images labels Mar 29, 2024
@SharpRake SharpRake requested a review from a team as a code owner March 29, 2024 22:35
Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for ornate-narwhal-088216 ready!

Name Link
🔨 Latest commit 0751437
🔍 Latest deploy log https://app.netlify.com/sites/ornate-narwhal-088216/deploys/660b4126006cab00083c7b73
😎 Deploy Preview https://deploy-preview-1482--ornate-narwhal-088216.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ltagliaferri ltagliaferri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments here, I think since this change has happened some of the tenses should be modified.

content/chainguard/chainguard-images/faq.md Outdated Show resolved Hide resolved
content/chainguard/chainguard-images/overview.md Outdated Show resolved Hide resolved
content/chainguard/chainguard-images/overview.md Outdated Show resolved Hide resolved
content/chainguard/chainguard-images/overview.md Outdated Show resolved Hide resolved
content/chainguard/chainguard-images/overview.md Outdated Show resolved Hide resolved
content/chainguard/chainguard-images/overview.md Outdated Show resolved Hide resolved
content/chainguard/chainguard-images/overview.md Outdated Show resolved Hide resolved
Signed-off-by: Mark Drake <[email protected]>
@SharpRake SharpRake merged commit fee49b4 into main Apr 1, 2024
9 checks passed
@SharpRake SharpRake deleted the overview-update branch April 1, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants