feat(cli): Dirk multi-node delegation support #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
force-pushed
the
feat/dirk-multinode
branch
from
183a0fd to
5dfc3b6
Compare
thedevbirb
approved these changes
Dec 3, 2024
mempirate
reviewed
Dec 3, 2024
mempirate
requested changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for creating signed delegations from multi-node Dirk instances (aka
DistributedAccount).Unfortunately, the BLS library we have used until now (
BLST) doesn't support M-N threshold signature recovery.See the related issue: supranational/blst#123
Since this operation is not overly complex, I've decided to implement it manually in
recover_signature.rs,following the C reference implementation in MCL directly for the Lagrange interpolation
The implementation is tested by generating a signed delegation against a 2-of-3 Dirk setup running locally and then verifying the signature against the combined public key.
One important caveat for testing is that the multi-node setup only works if you modify your
/etc/hostsfile to add aliases for localhost tolocalhost-1,localhost-2,localhost-3because it's the only way to have different valid TLS certificates on the same machine.