Skip to content

Commit

Permalink
clean up TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
sezna committed Jun 28, 2024
1 parent 405bd79 commit 764b054
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
3 changes: 3 additions & 0 deletions pete/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ fn compile(
for item in build_plan.items {
let (lockfile, buf, _build_plan) = load_project_and_dependencies(&item.path_to_source)?;
// TODO(alex) -- transitive dependencies, get these build plans too
// assignee: sezna
let lockfile_toml = toml::to_string(&lockfile)?;
let lockfile_path = path.join("petr.lock");
fs::write(lockfile_path, lockfile_toml)?;
Expand Down Expand Up @@ -271,6 +272,7 @@ fn compile(
timings.end("symbol resolution");

// TODO impl diagnostic for resolution errors
// assignee: sezna
if !resolution_errs.is_empty() {
dbg!(&resolution_errs);
}
Expand All @@ -283,6 +285,7 @@ fn compile(
timings.end("type check");

// TODO impl diagnostic for type errors
// assignee: sezna
if !type_errs.is_empty() {
dbg!(&type_errs);
}
Expand Down
5 changes: 4 additions & 1 deletion petr-vm/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -291,11 +291,14 @@ impl Vm {
self.state.registers.insert(dest, val);
}

// TODO things larger than a register
fn data_section_to_val(
&mut self,
data: &DataSectionEntry,
) -> Value {
// TODO
// need to use pointers for data larger than a reg/non-copy-types
// will involve stack memory
// assignee: sezna
match data {
DataSectionEntry::Int64(x) => Value(*x as u64),
DataSectionEntry::String(val) => {
Expand Down

0 comments on commit 764b054

Please sign in to comment.