remove outdated TODOs

ch-systems · Jun 29, 2024 · 16cbd8d · 16cbd8d
1 parent 534289d
commit 16cbd8d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 14 deletions.
diff --git a/petr-bind/src/binder.rs b/petr-bind/src/binder.rs
@@ -321,7 +321,9 @@ impl Binder {
                     petr_ast::AstNode::ImportStatement(stmt) => stmt.bind(binder),
                 });
                 let exports = BTreeMap::from_iter(exports);
-                // TODO do I need to track this module id?
+                // we don't need to track this module ID -- it just needs to exist,
+                // and all modules are iterated over in later stages of the compiler.
+                // So we can safely ignore the return value here.
                 let _module_id = binder.modules.insert(Module {
                     root_scope: scope_id,
                     exports,

diff --git a/petr-bind/src/impls.rs b/petr-bind/src/impls.rs
@@ -31,19 +31,14 @@ impl Bind for Expression {
                 bindings,
                 expression,
                 expr_id,
-            }) => {
-                binder.with_scope(ScopeKind::ExpressionWithBindings, |binder, scope_id| {
-                    for binding in bindings.iter() {
-                        let binding_id = binder.insert_binding(binding.clone());
-                        binder.insert_into_current_scope(binding.name.id, Item::Binding(binding_id));
-                    }
-                    // TODO: functions get inserted as Items with scopes, so we should probably
-                    // insert bound expressions as an Item with their own scope, not sure how yet.
-                    expression.bind(binder);
-                    binder.insert_expression(*expr_id, scope_id);
-                    //
-                })
-            },
+            }) => binder.with_scope(ScopeKind::ExpressionWithBindings, |binder, scope_id| {
+                for binding in bindings.iter() {
+                    let binding_id = binder.insert_binding(binding.clone());
+                    binder.insert_into_current_scope(binding.name.id, Item::Binding(binding_id));
+                }
+                expression.bind(binder);
+                binder.insert_expression(*expr_id, scope_id);
+            }),
             _ => (),
         }
     }