Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update provider internal fields logic #14

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Update provider internal fields logic #14

merged 4 commits into from
Jul 24, 2024

Conversation

webb-ben
Copy link
Member

No description provided.

@C-Loftus
Copy link
Member

It appears this was failing because of the fact that fields is a @property but this property does not have a setter defined. I fixed the geopandas provider. I did this just by bringing in the property definition into the same class and then creating a setter function. (Had to bring it over since I don't believe we can create a setter for a property that was inherited from the base class)

I am assuming this is the pattern you want but let me know if I misinterpreted

@webb-ben
Copy link
Member Author

Yes that is because of geopython/pygeoapi#1727

@webb-ben webb-ben merged commit 327e60f into master Jul 24, 2024
3 checks passed
@webb-ben webb-ben deleted the update-fields branch July 24, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants