Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Review - Chih-Yu Chinag #2

Open
ChihYuChiang opened this issue Dec 8, 2016 · 0 comments
Open

Peer Review - Chih-Yu Chinag #2

ChihYuChiang opened this issue Dec 8, 2016 · 0 comments

Comments

@ChihYuChiang
Copy link

ChihYuChiang commented Dec 8, 2016

Evaluation of final project by JongyoonBaik

Topic Excellent Satisfactory Needs Work
Coding style v
Coding strategy v
Presentation: graphs v
Presentation: tables v
Achievement, creativity v
Ease of access v

Remarks:

  • We encountered the same file size problem, and decided to just save all our clunky raw data files in another cloud storage. On the other hand, we used save() and load() functions to export and import necessary R Objects (such as a df), which are often way smaller than the original ones.
  • Typo in the sub-title of homepage, “a conflict resoultion method”.
  • Well documented foot note.
  • Formal and careful elaboration.
  • When comparing multiple year data of different regions, is it clearer to just use the over-laying line plots like the first figure in the home page?
  • I like the use of horizontal lines between main topics!
  • Code itself is clear. But since you did not provide original .R files of the analysis, and neither a clear work flow is described, it would be less convenient if try to reproduce the analysis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant