-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resolve Errors] [Review Warnings] Exceed error warning limit alert & counts read off the response body #699
Conversation
…the validation report is being downloaded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not working for me. I am seeing zeroes in the UI for error counts when there are 400
logic errors shown in /submission/latest
response, as well as errors shown in tables.
I think the Download Report
function is working well. Downloaded report shows 200,727 entries - I'm not sure what source I could compare that against to determine if that is the correct number of triggered validations.
API response
UI
…oll to the Download Validation Report button
@meissadia You have to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shindigira Sorry for that oversight and thanks for the clarification, I've updated my backend
@meissadia The filing alert has two mockups in figma where one has the link and one does not; should confirm with Natalia which she wants. Also, since it is outside the scope of this current PR's aim, we should deal with it in a different PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏾
@shindigira |
I don't think you had the chance to merge this great PR in before ya left on vacation, so going to do that now just to avoid some conflicts with related PRs. |
closes #623
closes #624
closes #630
closes #704
Changes
is_truncated
)How to Test
Screenshot