Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolve Errors] [Review Warnings] Exceed error warning limit alert & counts read off the response body #699

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented Jun 12, 2024

closes #623
closes #624
closes #630
closes #704

Changes

  • feat(Errors/Warnings): A field alert alert appears when the error/warnings limit is exceeded (i.e. is_truncated)
  • feat(Errors/Warnings): Single Field, Multi Field and Register counts now come from the data response object
  • enhancement(Download Validation Report): Added button loader
  • enhancement(Field Level Alert - Download Validation Report Link): Now scrolls to the Download Validation Report button

How to Test

  • Upload 1_000_000 errors
  • Navigate to Errors and/or Warnings
  • Ensure the counts properly match the data response object
  • The Field Level Alert appears when necessary
  • Test the Download Validation report link

Screenshot

Screenshot 2024-06-12 at 2 50 47 PM Screenshot 2024-06-12 at 2 50 47 PM Screenshot 2024-06-12 at 2 50 47 PM

@shindigira shindigira changed the title 623 624 exceed error warning limit [Resolve Errors] [Review Warnings] Exceed error warning limit alert & counts read off the response body Jun 12, 2024
Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working for me. I am seeing zeroes in the UI for error counts when there are 400 logic errors shown in /submission/latest response, as well as errors shown in tables.

I think the Download Report function is working well. Downloaded report shows 200,727 entries - I'm not sure what source I could compare that against to determine if that is the correct number of triggered validations.

API response

Screenshot 2024-06-12 at 4 46 08 PM

UI

screencapture-localhost-8899-filing-2024-123456789MEISBANK808-errors-2024-06-12-16_45_40

…oll to the Download Validation Report button
@shindigira
Copy link
Contributor Author

shindigira commented Jun 12, 2024

@meissadia You have to yarn update to the latest filing changes. Justin just merged in the count changes today.

@shindigira shindigira requested a review from meissadia June 12, 2024 23:12
Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shindigira Sorry for that oversight and thanks for the clarification, I've updated my backend

  • The numbers displayed in the UI seem to match what I'm seeing in the API. 👍🏾
  • Download report looks good 👍🏾
  • I do see one upload a new file link missing form the error Alert box
    • Screenshot 2024-06-13 at 12 54 12 PM

@shindigira
Copy link
Contributor Author

shindigira commented Jun 14, 2024

@shindigira Sorry for that oversight and thanks for the clarification, I've updated my backend

  • The numbers displayed in the UI seem to match what I'm seeing in the API. 👍🏾

  • Download report looks good 👍🏾

  • I do see one upload a new file link missing form the error Alert box

    • Screenshot 2024-06-13 at 12 54 12 PM

@meissadia The filing alert has two mockups in figma where one has the link and one does not; should confirm with Natalia which she wants. Also, since it is outside the scope of this current PR's aim, we should deal with it in a different PR.

@shindigira shindigira requested a review from meissadia June 14, 2024 16:00
Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏾

@natalia-fitzgerald
Copy link

@shindigira
Please see related feedback posted here: #578
Screenshot 2024-06-17 at 9 47 13 PM
Screenshot 2024-06-17 at 9 47 19 PM

@billhimmelsbach
Copy link
Contributor

billhimmelsbach commented Jun 18, 2024

I don't think you had the chance to merge this great PR in before ya left on vacation, so going to do that now just to avoid some conflicts with related PRs.

@billhimmelsbach billhimmelsbach merged commit 06787c2 into main Jun 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment