Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Node 22 (2nd attempt) #1097

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Upgrade to Node 22 (2nd attempt) #1097

merged 4 commits into from
Dec 20, 2024

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Dec 16, 2024 •
edited
Loading

Closes #1040

Changes

  • Updated Dockerfile to use new ghcr.io/cfpb/regtech/sbl/node-js-alpine:3.20 (node 22) base image.
  • Updated package.json -> engines to use Node v22
  • Updated .nvmrc to use v22

How to test this PR

  1. Pull branch
  2. nvm use
  3. yarn start to easily launch all backend services
  4. yarn docker-build-and-run to run the container version of the Frontend
  5. Update your .env file to run tests against the container version 
    SBL_PLAYWRIGHT_TEST_TARGET="http://localhost:8085"
  6. yarn playwright test --workers 4
  7. Verify all tests pass

@meissadia meissadia changed the title Upgrade to Node 22 Upgrade to Node 22 (2nd attempt) Dec 16, 2024
@meissadia meissadia marked this pull request as ready for review December 16, 2024 23:11
billhimmelsbach
billhimmelsbach approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Lots of work behind the scenes on this one, but glad it's all set.

@meissadia meissadia enabled auto-merge (squash) December 20, 2024 21:26
@meissadia meissadia merged commit 367f3dd into main Dec 20, 2024
10 checks passed
@meissadia meissadia deleted the 1040-node-22-v2 branch December 20, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach billhimmelsbach approved these changes

@tanner-ricks tanner-ricks Awaiting requested review from tanner-ricks tanner-ricks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Node 22
2 participants
@meissadia @billhimmelsbach