generated from cfpb/open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design review: Shared platform and filing platform (running checklist) #578
Comments
natalia-fitzgerald
changed the title
Design review - Filing platform (running checklist)
Design review: Filing platform (running checklist)
May 24, 2024
natalia-fitzgerald
changed the title
Design review: Filing platform (running checklist)
Design review: Shared platform and filing platform (running checklist)
May 29, 2024
8 tasks
shindigira
added a commit
that referenced
this issue
Jun 1, 2024
…utton (#598) closes #597 ## Note ### Tasks - Complete your user profile (associated financial institutions) - [x] Update small text in introduction to include link to email support staff and new URL for GLEIF. It would be best to swap in the whole block. ### Tasks - Complete your user profile (no associated financial institutions) - [x] Update small text in introduction to include link to email support staff and new URL for GLEIF. It would be best to swap in the whole block. - [x] Update body text under "Provide your financial institution details" to reference emailing support staff instead of "Add an additional financial institution" button/link. - [x] Change name of link/button to "Add an additional financial institution" - [x] Comment out "Add an additional financial institution" button/link - [x] For error alert links, remove numbering from "financial institution name" and "LEI" because there will only be one for MVP. You can comment out the numbering in code so that we can bring it back when we reveal the button/link post-MVP. - [x] Update text on error alert for "Your email domain" is not authorized (pre-clearance change). - [x] Add a breadcrumb to the warning alert notification screen that takes a user back to "Platform home" (un-authenticated). ## Notable Changes - content(Complete User Profile): Updated the language, commented out button - feat(complete user profile): toggle showing key index per error -- currently disabled - enhancement(Summary): breadcrumb is **standard** for all summaries -- if authenticated, routes to `/landing` otherwise `/` ## How to Test - Compare with the figma - Go through the two task lists above and verify each are correct; especially, last task. ## Screenshot - Normal <img width="410" alt="Screenshot 2024-05-29 at 12 28 38 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/0d290e0d-d8bf-4bc1-8fa9-74b7ce4cb1ad"> ## Screenshot - With Errors <img width="275" alt="Screenshot 2024-05-29 at 12 28 47 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/4f8cc1c9-d034-44fc-afae-a1a26fe18ba0"> ## Screenshot - Error Summary with breadcrumb <img width="793" alt="Screenshot 2024-05-29 at 6 13 26 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/6f1e8e09-af5e-46a4-b7f5-c0e778943557"> ## Screenshot - Warning Summary with breadcrumb <img width="778" alt="Screenshot 2024-05-29 at 6 28 03 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/f948593f-4b7f-42c5-b2f4-b2232f82811d"> ## References #578
This was referenced Jun 3, 2024
shindigira
added a commit
that referenced
this issue
Jun 3, 2024
Update the content and style of Update your user profile with [the latest design requests](#578). ## Changes - update copy of associated financial institutions section - remove now unnecessary class that was restricting the page content to 625px instead of 670px ## How to test this PR 1. Does Update your user profile match figma? ## Screenshots <img width="552" alt="Screenshot 2024-06-03 at 8 40 25 AM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/25283194-9677-44b3-a168-ef997d733ac7"> --------- Co-authored-by: shindigira <[email protected]>
@billhimmelsbach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Shared platform
✅ Shared platform home (unauthenticated)
✅ Complete your user profile (associated financial institutions)
✅ Complete your user profile (no associated financial institutions)
-- Reviewed on 6/3/2024 -- Clicking on the breadcrumb is going back to the blank Complete your user profile form -- @shindigira
-- Reviewed on 6/3/2024 --- Clicking on the breadcrumb does not go anywhere -- @shindigira
Shared platform home (authenticated)
Pipe character between Financial institution name and LEI should have two spaces before and after--- Moved to Consolidated list of user interface updates #800View your user profile
Pipe character between Financial institution name and LEI should have two spaces before and after--- Moved to Consolidated list of user interface updates #800✅ View your financial institution profile
✅ Update your financial institution profile
Filing home
Pipe character between Financial institution name and Year should have two spaces before and after--- Moved to Consolidated list of user interface updates #800Confirm that card border is using #B4B5B6 (Gray 40). If it is not update to this color.--- Moved to Consolidated list of user interface updates #800✅ Provide type of financial institution
Upload file
When a user clicks the "Save and continue" button before they have completed the requirements for the "Upload file" step they should only see an error alert positioned at the bottom of the page that says: "File upload and validation checks must be completed to save and continue." Reference 4 scenarios in design file (mock-up).--- Moved to Consolidated list of user interface updates #800Save and continue
on all pages (Phase 1) #552 @meissadiaResolve errors
Change space under the following section heading + body text from 45px to 30px (space under "Single-field errors + body text," "Multi-field errors + body text," and "Register level errors + body text".--- Moved to Consolidated list of user interface updates #800Field-level warning alert for number of errors for validation code exceed display limit--- Moved to Consolidated list of user interface updates #800"Download report" link should be an inline link - Regular weight (400) instead of Medium weight (500)--- Moved to Consolidated list of user interface updates #800Save and continue
on all pages (Phase 1) #552 @meissadiaReview warnings
Field-level warning alert for number of errors for validation code exceed display limit--- Moved to Consolidated list of user interface updates #800"Download report" link should be an inline link - Regular weight (400) instead of Medium weight (500)--- Moved to Consolidated list of user interface updates #800Save and continue
on all pages (Phase 1) #552 @meissadiaProvide point of contact
Fix error status styling for state selector: [Point of Contact] State Selector - Error/Hover/Focus styling updates #561 -- @shindigira --- @billhimmelsbach - Moving this to the front-end nice to have issue--- Moved to Consolidated list of user interface updates #800Pipe character between Financial institution name and Year in step indicator should have two spaces before and after--- Moved to Consolidated list of user interface updates #800✅ Sign and submit
"Confirm your filing point of contact" section
Global
Update nav bar items and styling and related breadcrumbs@ojbravoMobile nav items: Home, Filing, Profile (still links to View your user profile), and Log out--- Moved to Consolidated list of user interface updates #800Here's a mock-up:
Updated on 6/27/2024:
Loosely based on the consumerfinance.gov mobile megamenu. Let's pull the code that we can. https://www.consumerfinance.gov
The text was updated successfully, but these errors were encountered: