Skip to content

Commit

Permalink
Added confirmation_id and contact_info to Submission and Filing DAO/DTO
Browse files Browse the repository at this point in the history
  • Loading branch information
jcadam14 committed Jan 17, 2024
1 parent d4d13c7 commit 911ab26
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/entities/models/dao.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class SubmissionDAO(Base):
validation_ruleset_version: Mapped[str]
validation_json: Mapped[dict[str, Any]] = mapped_column(JSON, nullable=True)
filing: Mapped[str] = mapped_column(ForeignKey("filing.id"))
confirmation_number: Mapped[str]

def __str__(self):
return f"Submission ID: {self.id}, Submitter: {self.submitter}, State: {self.state}, Ruleset: {self.validation_ruleset_version}, Filing: {self.filing}"
Expand All @@ -42,8 +43,8 @@ class FilingDAO(Base):
lei: Mapped[str]
state: Mapped[FilingState] = mapped_column(SAEnum(FilingState))
filing_period: Mapped[int] = mapped_column(ForeignKey("filing_period.id"))
institution_snapshot_id = Mapped[str] # not sure what this is

institution_snapshot_id: Mapped[str]
contact_info: Mapped[str]

# Commenting out for now since we're just storing the results from the data-validator as JSON.
# If we determine building the data structure for results as tables is needed, we can add these
Expand Down
2 changes: 2 additions & 0 deletions src/entities/models/dto.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class SubmissionDTO(BaseModel):
validation_ruleset_version: str | None = None
validation_json: Dict[str, Any] | None = None
filing: int
confirmation_number: str | None = None


class FilingDTO(BaseModel):
Expand All @@ -23,6 +24,7 @@ class FilingDTO(BaseModel):
state: FilingState
filing_period: int
institution_snapshot_id: str
contact_info: str


class FilingPeriodDTO(BaseModel):
Expand Down

0 comments on commit 911ab26

Please sign in to comment.