5 create sqs wrapper and services for polling messages #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-between-local-and-aws Updated to be able to run things locally in docker
lchen-2101
reviewed
Dec 27, 2024
| ), | ||
| backoff_limit=3, | ||
| # keep jobs around for a day before deleting | ||
| ttl_seconds_after_finished=86400 |
There was a problem hiding this comment.
for debugging purposes I'm guessing? or does this help with performance? I don't think jobs reuse containers, right?
also, I'm guessing this is just POC for now, and will be rolled out to the other 2 processes as well?
lchen-2101
reviewed
Dec 27, 2024
Comment on lines
+91
to
+93
| #slice is start indice inclusive, so 0 to max_errors will return 1000000 errors (0-999999) if the | ||
| #max_errors is 1000000 and there are more than that. Adding +1 actually returns | ||
| #max_errors + 1 which would be one more than the max_errors intended |
There was a problem hiding this comment.
right, although maybe it doesn't matter for the new paradigm, but the intent was to make sure the downstream special case triggers, i.e. adding that extra line in the csv file, since at the max_errors, it doesn't trigger, but max_errors + 1 triggers the line to be added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5
Please read all the comments in the associated story, I've documented everything there.