Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flush and refresh back in #98

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

jcadam14
Copy link
Contributor

Switched code back to using flush and refresh. The new mapping table and DAO seems to need it to fully build out the FI object being returned.

@jcadam14 jcadam14 self-assigned this Jan 18, 2024
@jcadam14 jcadam14 linked an issue Jan 18, 2024 that may be closed by this pull request
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/entities/repos
  institutions_repo.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Collaborator

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101 lchen-2101 merged commit fe34b42 into main Jan 19, 2024
3 checks passed
@lchen-2101 lchen-2101 deleted the 95-fix-institution-repo-upsert-return-value branch January 19, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix institution repo upsert return value
2 participants