Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

93 synchronize linting setup between gh actions and local development #94

Merged
merged 4 commits into from
Jan 19, 2024
+7 −3
Merged

93 synchronize linting setup between gh actions and local development #94

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12b40a4
Added versions to the linter actions
jcadam14 Jan 17, 2024
ba261a2
ruff-action doesn't allow for compatible versioning, just explicit ve…
jcadam14 Jan 17, 2024
8863383
Removed ^ from ruff version in pyproject.toml to force specific version
jcadam14 Jan 18, 2024
4f64442
Changed black in toml to be ~ to keep with just patch versions concept
jcadam14 Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/linters.yml
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think we might also need to do the same with the toml file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated toml to remove the ^ for the ruff version

Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,12 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: psf/black@stable
with:
version: "~= 23.7.0"
ruff:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: chartboost/ruff-action@v1
- uses: chartboost/ruff-action@v1
with:
version: 0.0.278
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ alembic = "^1.12.0"
pydantic-settings = "^2.0.3"

[tool.poetry.group.dev.dependencies]
ruff = "^0.0.278"
ruff = "0.0.278"
black = "^23.7.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing black?

httpx = "^0.24.1"
pytest = "^7.4.0"
Expand Down
Loading