Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/89 add details in mapping model #92

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Feature/89 add details in mapping model #92

merged 3 commits into from
Jan 17, 2024

Conversation

lchen-2101
Copy link
Collaborator

closes #89

@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  src/entities/models
  dao.py
  dto.py
  src/entities/repos
  institutions_repo.py
Project Total  

This report was generated by python-coverage-comment-action

jcadam14
jcadam14 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@jcadam14 jcadam14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume we need a task in the sbl-project repo to update the mock_data json to remove the ids field and use types as expected here?

@lchen-2101 lchen-2101 merged commit 9212ba0 into main Jan 17, 2024
3 checks passed
@lchen-2101 lchen-2101 deleted the feature/89_add_details_in_mapping_model branch January 17, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcadam14 jcadam14 jcadam14 approved these changes

@hkeeler hkeeler Awaiting requested review from hkeeler

@guffee23 guffee23 Awaiting requested review from guffee23

@nargis-sultani nargis-sultani Awaiting requested review from nargis-sultani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update institution model to include sbl institution type's other type
2 participants
@lchen-2101 @jcadam14