fix: updated upsert to flush and refresh the dao before returning #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
jcadam14
reviewed
Jan 8, 2024
There was a problem hiding this comment.
From what I have read and seen in my own usage of it, the session.merge() function does what we would need here. If the object isn't in the db (based on the PK), it'll add it. If it is, it'll udpate (so upsert). The merge function returns the object that was added/updated in the db with the new values. So I think we could use that here.
There was a problem hiding this comment.
perfect, I even saw you using it... didn't click here... will try it out, thanks.
jcadam14
approved these changes
Jan 8, 2024
lchen-2101
deleted the
fix/85_fix_upsert_serialization_error_on_response
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #85