Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update institutions dto to include relational models instead of just the codes #72

Merged
merged 1 commit into from
Dec 28, 2023
Merged

feat: update institutions dto to include relational models instead of just the codes #72

merged 1 commit into from
Dec 28, 2023

Conversation

lchen-2101
Copy link
Collaborator

closes #71

@github-actions GitHub Actions
Copy link

Coverage report

The coverage rate went from 86.64% to 86.73% ⬆️
The branch rate is 85%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

src/entities/models/init.py

100% of new lines are covered (100% of the complete file).

src/entities/models/dto.py

100% of new lines are covered (100% of the complete file).

src/routers/institutions.py

100% of new lines are covered (100% of the complete file).

jcadam14
jcadam14 approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@jcadam14 jcadam14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lchen-2101 lchen-2101 merged commit 05b9237 into main Dec 28, 2023
3 checks passed
@lchen-2101 lchen-2101 deleted the feature/71_add_relational_models_to_institutions branch December 28, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcadam14 jcadam14 jcadam14 approved these changes

@nargis-sultani nargis-sultani Awaiting requested review from nargis-sultani

@guffee23 guffee23 Awaiting requested review from guffee23

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach

@hkeeler hkeeler Awaiting requested review from hkeeler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update institutions dto to include the relational models
2 participants
@lchen-2101 @jcadam14