Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/40 update institutions models new #60

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Features/40 update institutions models new #60

merged 5 commits into from
Dec 11, 2023

Conversation

nargis-sultani
Copy link
Contributor

No description provided.

@nargis-sultani nargis-sultani added the backend backend development label Dec 8, 2023
This was linked to issues Dec 8, 2023
Update institutions models #40
Closed
Create alembic script for institutions table update #48
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

Coverage report

The coverage rate went from 84.29% to 86.28% ⬆️
The branch rate is 85%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

src/entities/models/init.py

100% of new lines are covered (100% of the complete file).

src/entities/models/dao.py

100% of new lines are covered (100% of the complete file).

src/entities/models/dto.py

100% of new lines are covered (100% of the complete file).

src/entities/repos/institutions_repo.py

100% of new lines are covered (96.77% of the complete file).

src/routers/institutions.py

100% of new lines are covered (100% of the complete file).

@nargis-sultani nargis-sultani changed the title Features/40 updateinstitutions models new Features/40 update institutions models new Dec 8, 2023
lchen-2101
lchen-2101 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101 lchen-2101 merged commit 648f07f into main Dec 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchen-2101 lchen-2101 lchen-2101 approved these changes

@hkeeler hkeeler Awaiting requested review from hkeeler

@jcadam14 jcadam14 Awaiting requested review from jcadam14

Assignees
No one assigned
Labels
backend backend development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create alembic script for institutions table update Update institutions models
2 participants
@nargis-sultani @lchen-2101