Changes the get_institutions query to check for domain equality instead of a 'like' query #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of a 'like' query Updates the pytest in test_institutions_repo.test_get_institutions_by_domain to check for domain equality and to verify generic text strings won't find domains Domain query will use the exact user domain instead of a generic text string like 'bank'. This forces that concept.
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)src/entities/repos/institutions_repo.py
|
…institutions_repo.py with black this time black linter in GitHub actions was failing
lchen-2101
reviewed
Dec 5, 2023
…the join to not be returned Tried to "pretty" the code but associating the join at the start. However this caused a query for all institutions to only return those where the inner join didn't come back empty.
Added an extra institution to make the query for institutions a little more comprehensive. Because of the bug, the test_add_institution was providing a false positive with returned banks == 3 because the join was causing the newly added bank that did not have a domain to not be returned.
lchen-2101
deleted the
56-update-institution-retrieval-with-domain-search-to-be-exact-match
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the pytest in test_institutions_repo.test_get_institutions_by_domain to check for domain equality and to verify generic text strings won't find domains
Domain query will use the exact user domain instead of a generic text string like 'bank'. This forces that concept.