Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket # 45: creating a new branch #54

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Ticket # 45: creating a new branch #54

merged 1 commit into from
Nov 29, 2023

Conversation

nargis-sultani
Copy link
Contributor

Recreated the branch

@nargis-sultani nargis-sultani added the backend backend development label Nov 29, 2023
@nargis-sultani nargis-sultani linked an issue Nov 29, 2023 that may be closed by this pull request
Running Alembic on App Startup #45
Closed
@github-actions GitHub Actions
Copy link

Coverage report

The coverage rate went from 84.93% to 84.32% ⬇️
The branch rate is 85%.

50% of new lines are covered.

Diff Coverage details (click to unfold)

src/main.py

50% of new lines are covered (82.92% of the complete file).
Missing lines: 25, 26, 27, 28, 29

lchen-2101
lchen-2101 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101 lchen-2101 merged commit c485d78 into main Nov 29, 2023
3 checks passed
@lchen-2101 lchen-2101 deleted the features/45_running_alembic_on_app_startup_new_branch branch November 29, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchen-2101 lchen-2101 lchen-2101 approved these changes

@hkeeler hkeeler Awaiting requested review from hkeeler

@guffee23 guffee23 Awaiting requested review from guffee23

Assignees
No one assigned
Labels
backend backend development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running Alembic on App Startup
2 participants
@nargis-sultani @lchen-2101