Ticckt 45, running almebic on startup #51
Conversation
|
Also, all the alembic tests pass for me locally. Only this test fails for me: |
|
I figured why the alembic tests are failing. I am making the changes. |
|
quick note, we don't want to move the |
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)src/main.py
|
| # Interpret the config file for Python logging. | ||
| # This line sets up loggers basically. | ||
| if config.config_file_name is not None: | ||
| fileConfig(config.config_file_name) |
There was a problem hiding this comment.
why were these changed from above?
| # add your model's MetaData object here | ||
| # for 'autogenerate' support | ||
| # from myapp import mymodel |
There was a problem hiding this comment.
why remove this comment? this is a continuation from the previous line
| config.set_main_option("sqlalchemy.url", INST_CONN) | ||
|
|
||
| # end specific SBL configuration | ||
| INST_DB_PATH = f"{INST_DB_USER}:{INST_DB_PWD}@{INST_DB_HOST}/{INST_DB_NAME}" |
There was a problem hiding this comment.
what's this new variable?
|
Let's try cleaning this up a bit, looks like a lot more changes than there really is, making it harder to review, and it would be easy to miss the change from |
|
@lchen-2101 I will clean up and create a new branch. |
It has been tested and both running alembic on startup and running alembic manually work.
On startup, "alembic upgrade head" is executed.