Institutions LEI Bug #49
Conversation
Added a check for when no institutions are present. Added corresponding test.
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)src/entities/repos/institutions_repo.py
|
src/routers/institutions.py
Outdated
| @@ -53,6 +53,8 @@ async def create_institution( | |||
| async def get_associated_institutions(request: Request): | |||
| user: AuthenticatedUser = request.user | |||
| email_domain = get_email_domain(user.email) | |||
| if not user.institutions: | |||
| return [] | |||
| associated_institutions = await repo.get_institutions(request.state.db_session, user.institutions) | |||
There was a problem hiding this comment.
let's also add the safe guard in the repo, so empty list of leis doesn't return everything
There was a problem hiding this comment.
The search by list of leis was added functionality to this endpoint. It would send all institutions back if nothing was specified (domain, pg #, count). For clarification, we want to remove this feature to be lei specific search?
There was a problem hiding this comment.
no, this stays as is, but the repo should have a safe guard as well; right now the repo treats both None and empty list as the same, which shouldn't be the case.
There was a problem hiding this comment.
second thought, just have the logic in the repo is good enough, so the router doesn't need to have this check.
Closes #46