Ticket 131: seed denied domains table #132
Conversation
nargis-sultani
requested review from
lchen-2101,
jcadam14,
hkeeler and
guffee23
Coverage report
This PR does not seem to contain any modification to coverable code. |
There was a problem hiding this comment.
We should check the full list was inserted, either by referencing the list in alembic script or copying the expected seed data and comparing it against a select all
| @@ -112,16 +112,169 @@ def test_denied_domains_data_seed(alembic_runner: MigrationContext, alembic_engi | |||
| # Migrate up to, but not including this new migration | |||
| alembic_runner.migrate_up_before("d6e4a13fbebd") | |||
|
|
|||
| denied_domains_inserted = [ | |||
There was a problem hiding this comment.
Could you alphabetize this list? It'll make it easier to see like-domains and know where to put new ones, rather than always tacking to the end of the list, which makes it more likely to have merge conflicts.
If you're using VSCode, there's a handy Sort Lines Ascending command for just this sort (sorry) of thing:
Nope, I talked with Nargis in MM about adding a full check in the pytest to verify all domains made it in the insert so we're good! |
closes #131