Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/87 add versioning to fi tables #101

Merged
merged 5 commits into from
Feb 12, 2024
Merged

Feature/87 add versioning to fi tables #101

merged 5 commits into from
Feb 12, 2024

Conversation

lchen-2101
Copy link
Collaborator

closes #87

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  src
  main.py 37
  src/entities
  listeners.py 20, 22-24, 46-57
  src/entities/models
  dao.py
  dto.py
  src/entities/repos
  institutions_repo.py
  src/routers
  institutions.py
Project Total  

This report was generated by python-coverage-comment-action

@lchen-2101 lchen-2101 marked this pull request as ready for review February 7, 2024 16:29
jcadam14
jcadam14 reviewed Feb 7, 2024
View reviewed changes
src/entities/repos/institutions_repo.py Outdated Show resolved Hide resolved
src/entities/listeners.py Show resolved Hide resolved
src/entities/models/dao.py Show resolved Hide resolved
jcadam14
jcadam14 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@jcadam14 jcadam14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lchen-2101 lchen-2101 merged commit df5a0d9 into main Feb 12, 2024
3 checks passed
@lchen-2101 lchen-2101 deleted the feature/87_add_versioning_to_fi_tables branch February 12, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcadam14 jcadam14 jcadam14 approved these changes

@hkeeler hkeeler Awaiting requested review from hkeeler

@guffee23 guffee23 Awaiting requested review from guffee23

@nargis-sultani nargis-sultani Awaiting requested review from nargis-sultani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Institution Snapshot
2 participants
@lchen-2101 @jcadam14