68 correct validation description errors #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several changes and discrepancies existed between the python code and CSV. This corrects those issues.
To pass the Ruff linter
To pass the linter action
To keep consistent with the CSV. This structure is stripped away though during the automated testing in #65
jcadam14
requested review from
hkeeler,
guffee23,
lchen-2101 and
nargis-sultani
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)regtech_data_validator/phase_validations.py
|
so the pytest passes and the code and csv are in sync
align with csv updates
jcadam14
added a commit
that referenced
this pull request
May 3, 2024
These are all changes to make our python code consistent with the CVS located at https://raw.githubusercontent.com/cfpb/sbl-content/main/fig-files/validation-spec/2024-validations.csv This goes hand in hand with issue #65 Of note is the addition of W0680, which checks the Census GEO id against the census CSV. Majority of the changes involved missing spaces, copy/paste errors, etc. The updates to this file are still in progress as there are 4 errors (E0940, E1120, E1300, E1480) that have descriptions that Chynna and Shomari are looking into to verify if the CSV is correct. So this PR is simply to get a head start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all changes to make our python code consistent with the CVS located at https://raw.githubusercontent.com/cfpb/sbl-content/main/fig-files/validation-spec/2024-validations.csv
This goes hand in hand with issue #65
Of note is the addition of W0680, which checks the Census GEO id against the census CSV.
Majority of the changes involved missing spaces, copy/paste errors, etc.
The updates to this file are still in progress as there are 4 errors (E0940, E1120, E1300, E1480) that have descriptions that Chynna and Shomari are looking into to verify if the CSV is correct. So this PR is simply to get a head start.