61 : update po validation ids #62
Conversation
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. Diff Coverage details (click to unfold)regtech_data_validator/phase_validations.py
|
aharjati
requested review from
hkeeler,
guffee23,
lchen-2101 and
nargis-sultani
| @@ -2065,7 +2064,7 @@ def get_phase_1_and_2_validations_for_lei(lei: str | None = None): | |||
| ), | |||
| SBLCheck( | |||
| meets_multi_value_field_restriction, | |||
| id="W0942", | |||
| id="W0951", | |||
There was a problem hiding this comment.
checking with @sthomas93 on whether this is correct, from the excel sheet, this is still W0942
There was a problem hiding this comment.
It is w0902 in the excel file now, should I update it?
There was a problem hiding this comment.
wait for Shomari's reponse, but the one you were referencing is ethnicity, not race
There was a problem hiding this comment.
@lchen-2101 @nargis-sultani The field "po_1_race.multi_value_field_restriction" should have the validation ID W0942. The field "po_1_ethnicity.multi_value_field_restriction" should have the validation ID W0902. If ethnicity is being referenced per Le's comment then it should be W0902.
There was a problem hiding this comment.
Thanks, @sthomas93.
@lchen-2101 Just updated the value for the field "po_1_race.multi_value_field_restriction".
There was a problem hiding this comment.
👍 on the code side. I haven't done a one-for-one check that every one of the entries match what's in the spreadsheet, but it sounds like @lchen-2101 and @sthomas93 were working through that, and we've got the last item fixed up?
closes #61 update - update the principal owner validation IDs to match new ones - update devcontainer docker file to run pip install separately. (background: devcontainer was failing with old setup) --------- Co-authored-by: Aldrian Harjati <[email protected]> Co-authored-by: Nargis Sultani <[email protected]>
closes #61
update