Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devcontainer dockerfile update: remove parent paths on pyproject and poetry files #53

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

aharjati
Copy link
Contributor

Fixed bug where user cannot setup dev-container in VS code
Issue
docker cannot get pyproject and poetry files because incorrect path
Fix:
Removing the parent path because we already defined parent path in devcontainer's build context

Test:
Successfully load devcontainer in my and nargis laptop

@github-actions
Copy link

Coverage report

The coverage rate went from 82.26% to 82.26% ⬇️
The branch rate is 68%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@aharjati aharjati linked an issue Sep 20, 2023 that may be closed by this pull request
Copy link
Collaborator

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101 lchen-2101 merged commit d893989 into main Sep 21, 2023
@lchen-2101 lchen-2101 deleted the bugs/51_devcontainer_docker branch September 21, 2023 14:36
jcadam14 pushed a commit that referenced this pull request May 3, 2024
…poetry files (#53)

Fixed bug where user cannot setup dev-container in VS code
Issue
docker cannot get pyproject and poetry files because incorrect path
Fix:
Removing the parent path because we already defined parent path in
devcontainer's build context

Test:
Successfully load devcontainer in my and nargis laptop

---------

Co-authored-by: Aldrian Harjati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devcontainer dockerfile failed
2 participants