Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add black formatter extension to dev-container json #46

Merged
merged 1 commit into from
Sep 14, 2023
Merged

add black formatter extension to dev-container json #46

merged 1 commit into from
Sep 14, 2023

Conversation

aharjati
Copy link
Contributor

Currently, we have to install black-formatter manually after reloading/rebuilding dev-container, and occasionally, we forget to re-install this extension that caused formatting issue.

This update will install black-formatter automatically when rebuilding/creating dev-container.

@github-actions
Copy link

Coverage report

The coverage rate went from 81.08% to 81.08% ⬆️
The branch rate is 65%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

hkeeler
hkeeler approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@hkeeler hkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure this is all correct. Just curious why the one setting goes from black to none? Is that like a difference for when you have black as a VS Code plugin vs. installed via Python package or something? The mysteries of VS Code's configs...

I'm just gonna have to trust you on this one @aharjati. 😄

@aharjati
Copy link
Contributor Author

I'm sure this is all correct. Just curious why the one setting goes from black to none? Is that like a difference for when you have black as a VS Code plugin vs. installed via Python package or something? The mysteries of VS Code's configs...

I'm just gonna have to trust you on this one @aharjati. 😄

Thanks! 😄
it's recommended by black-formatter to add that line. https://marketplace.visualstudio.com/items?itemName=ms-python.black-formatter
Screenshot 2023-09-14 at 12 29 50 PM

lchen-2101
lchen-2101 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aharjati aharjati merged commit 054c3a1 into main Sep 14, 2023
@aharjati aharjati deleted the features/add_vscode_black_formatter branch September 15, 2023 16:39
jcadam14 pushed a commit that referenced this pull request May 3, 2024
@aharjati
add black formatter extension to dev-container json (#46)
9eff87f 
Currently, we have to install black-formatter manually after
reloading/rebuilding dev-container, and occasionally, we forget to
re-install this extension that caused formatting issue.

This update will install black-formatter automatically when
rebuilding/creating dev-container.

Co-authored-by: Aldrian Harjati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchen-2101 lchen-2101 lchen-2101 approved these changes

@hkeeler hkeeler hkeeler approved these changes

@guffee23 guffee23 Awaiting requested review from guffee23

@ethanbienstock ethanbienstock Awaiting requested review from ethanbienstock

@nargis-sultani nargis-sultani Awaiting requested review from nargis-sultani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aharjati @hkeeler @lchen-2101