Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly offset the index for batched validation #280

Merged
merged 4 commits into from
Nov 14, 2024
Merged

fix: correctly offset the index for batched validation #280

merged 4 commits into from
Nov 14, 2024

Conversation

lchen-2101
Copy link
Collaborator

closes #275

@lchen-2101 lchen-2101 requested a review from jcadam14 November 14, 2024 18:37
@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  src/regtech_data_validator
  validator.py
Project Total  

This report was generated by python-coverage-comment-action

@lchen-2101 lchen-2101 merged commit b2ec8d3 into main Nov 14, 2024
6 checks passed
@lchen-2101 lchen-2101 deleted the fix/275_fix_offset_for_batch branch November 14, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcadam14 jcadam14 jcadam14 approved these changes

@hkeeler hkeeler Awaiting requested review from hkeeler

@guffee23 guffee23 Awaiting requested review from guffee23

@nargis-sultani nargis-sultani Awaiting requested review from nargis-sultani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] _filter_valid_records incorrectly filters out results from batch validations
2 participants
@lchen-2101 @jcadam14