Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BEM fixes #1963

Merged
merged 1 commit into from
Apr 24, 2024
Merged

BEM fixes #1963

merged 1 commit into from
Apr 24, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Apr 24, 2024 •
edited
Loading

Some follow up to #1919

Changes

  • Update modifier name to correct BEM naming.
  • Remove unused content-l_col__before-divider
  • Update @heading variables to use dashes.

Testing

  1. PR checks should pass. Check the block helper text in the PR preview. It should wrap to its own line https://cfpb.github.io/design-system/components/helper-text#block-helper-text

@netlify Netlify
Copy link

netlify bot commented Apr 24, 2024

✅ Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 0c6008d
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/66294f3260225a0008985382
😎 Deploy Preview https://deploy-preview-1963--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

contolini
contolini approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✊

@anselmbradford anselmbradford merged commit b4501db into main Apr 24, 2024
8 checks passed
@anselmbradford anselmbradford deleted the ans_bem_fixes branch April 24, 2024 18:55
@anselmbradford anselmbradford added the lerna-changelog/bug lerna label. DO NOT MODIFY label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@contolini contolini contolini approved these changes

Assignees
No one assigned
Labels
lerna-changelog/bug lerna label. DO NOT MODIFY
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anselmbradford @contolini