Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some modifiers to updated BEM | Clean up CSS nesting | add stylelint BEM rule #1957

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

anselmbradford
Copy link
Member

Some follow up to #1919

Fixes #1955

Changes

  • Fix some modifiers to updated BEM.
  • Clean up CSS unit helper redundant nesting.
  • add stylelint BEM rule.

Testing

  1. yarn lint should pass.

@anselmbradford anselmbradford added the lerna-changelog/bug lerna label. DO NOT MODIFY label Apr 18, 2024
Copy link

netlify bot commented Apr 18, 2024

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 95508b6
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/6621350c5f74980008227b47
😎 Deploy Preview https://deploy-preview-1957--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anselmbradford anselmbradford merged commit 5007617 into main Apr 18, 2024
8 checks passed
@anselmbradford anselmbradford deleted the ans_bem_followup branch April 18, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lerna-changelog/bug lerna label. DO NOT MODIFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Success/alert notification link text fails contrast check
1 participant