Upgrade to React v19 and Storybook v8 #396
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #393
Keep up-to-date with the latest major React release. For compatibility, also requires upgrading to Storybook v8.
Changes
npx react-codemod update-react-imports
npx codemod@latest react/19/migration-recipe
(no changes)npx types-react-codemod@latest preset-19 ./
import type { JSX } from 'react';
does address a TSC error, so those have been kept in placenpx storybook@latest migrate mdx-to-csf --glob "src/**/*.stories.mdx"
npx storybook@latest migrate csf-2-to-3 --glob="**/*.stories.tsx" --parser=tsx
npx storybook@latest upgrade
storyStoreV7
npx storybook migrate find-implicit-spies --glob="./src/**/*.stories.*"
(None found)argTypesRegex
yarn remove display-element-css
@storybook/jest
with@storybook/test
per guidanceHow to test this PR
yarn test
)sbl-frontend > yarn && yarn test:e2e:snapshot --headless
TODO
Potential blocker: Github actions failure -- Hanging process during
yarn test:ci
Jan 30 - This seems to be an intermittent error because, right now, the tests are passing without the hanging process 🤷🏾♂️
Note: this seems to be a pre-existing issue not caused by these upgrades
git checkout main && git pull && yarn && yarn test:ci
shows the same failureAttempted workarounds:
yarn run vitest --reporter=hanging-process
shows lots of the following, enough to overrun my terminal buffer, so I'm working to capture the full output for further evaluationvitest
does not fix ityarn run vitest run --pool=threads