fix(Navbar): CFPB logo always takes you to consumerfinance.gov #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billhimmelsbach
requested review from
meissadia and
shindigira
as code owners
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
billhimmelsbach
changed the title
natalia-fitzgerald
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
@billhimmelsbach
Looks good! Clicking the CFPB logo takes me to the CFPB homepage as expected.
|
@billhimmelsbach Don't forget to close issue #295. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CFPB logo should always navigate to consumerfinance.gov instead of a generic / to allow for applications with their own routing that are using the navbar, as per @natalia-fitzgerald's designs.
Changes
hrefto behttps://www.consumerfinance.gov/How to test this PR
Notes
hrefinto a prop, but clicking this logo across all CFPB properties should take you towww.consumerfinance.gov, so it's better to hardcode it for consistency