-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS/DSR Hover and Focus styling | Text input/Checkbox/Radio button/Selects #357
Comments
@natalia-fitzgerald Re: status styles - Radio/Select in DSR do not currently implement a |
@meissadia Sigmund opened an ticket for a styling issue with the error status for the Select component.cfpb/sbl-frontend#561 |
I like the approach of keeping the hover state the same across status'. I believe that helps to keep things consistent while also reducing the amount of styles for the various status. I guess the only open question in my mind would be what are all of the components the status styling be introduced to. Is it the list above? Are there additional ones (EG text area)? Regardless this seems like a good starting point. |
@itsmedavep So the components which should have status states are:
For the purposes of this initial effort we would prioritize the components which appear in the data submission platform:
The following do not appear in the data submission platform:
Another question I have, which is out of scope but related, is whether we may want to consider applying this approach (Pacific hover and focus) to other interactive elements, like buttons and links. But yes, as a first step I'd like to confirm that this approach is appealing to the team and if so we will begin to update the input components that appear on the data submission platform first. |
closes #580 ## Changes - style(secondary button): updated state and pipe styling - Upload - missed small text update - Summary - links open a new window | Normal | Hover | Focus | Active | |--|--|--|--| |<img width="488" alt="Screenshot 2024-06-03 at 5 56 40 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/ae42839a-73a6-4de0-b7cb-a79f60e64bf0">|<img width="479" alt="Screenshot 2024-06-03 at 5 53 36 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/2fedff37-c0e1-4757-846a-131b78459933">|<img width="483" alt="Screenshot 2024-06-03 at 5 53 48 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/a1181026-c99b-4558-b821-dbf77d806263">|<img width="466" alt="Screenshot 2024-06-03 at 6 05 58 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/521b388c-1aea-4fad-a524-5a5d54417aff">| ## Reference - cfpb/design-system-react#357 (comment)
Exploration
I am looking to explore the following approach to the hover and focus styling for input fields.
Proposal
Audit of current state
In the CFPB Design System (and therefore the DSR) The current approach to hover and focus colors is inconsistently implemented. For some inputs we mirror status colors for hover and focus and for others we use Pacific blue.
I would like to audit the landscape of what we currently do in order to then make a decision as to what we might want to do moving forward. This change would likely start at the DS and then reach the DSR and our app. My goal is to reduce the maintenance burden, increase consistency, implement state and status styling across components, and make our form inputs more usable.
Checkboxes
Text input/Text area
Select
Radio buttons
@meissadia @shindigira - Are the status state styles for select, multi-select, and radio buttons defined in the DS or DSR
The text was updated successfully, but these errors were encountered: