Squash Django migrations (step 1) #8701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change squashes Django migrations for all Django apps with more than 3 migrations. See our internal squashing documentation here [0] and Django's general docs on squashing here [1]. Migration squashing requires multiple steps: 1. Commit squashed migrations, and deploy them. 2. Delete migration files that were squashed, and remove "replaces" in the squashed migration files. Deploy this change. This squashing removes some RunPython code that is only compatible with PostgreSQL; after this squash it will once again be possible to migrate a SQLite database. [0] https://cfpb.github.io/consumerfinance.gov/migrations/#squashing-migrations [1] https://docs.djangoproject.com/en/5.1/topics/migrations/#squashing-migrations
chosak
added a commit
to chosak/consumerfinance.gov
that referenced
this pull request
Dec 30, 2024
These migrations include PostgreSQL-specific syntax and will not run properly against SQLite. This commit temporarily comments them out. A preferred solution is to squash these migrations away, which is proposed in consumerfinance.gov cfpb#8701.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change squashes Django migrations for all Django apps with more than 3 migrations. See our internal squashing documentation here and Django's general docs on squashing here.
Migration squashing requires multiple steps:
the squashed migration files. Deploy this change.
This squashing removes some RunPython code that is only compatible with PostgreSQL; after this squash it will once again be possible to migrate a SQLite database.
This PR also updates our Postgres test database file to have the latest and squashed migrations.