Skip to content

Commit

Permalink
Merge pull request #314 from cfpb/words
Browse files Browse the repository at this point in the history
Updated Labels and Links
  • Loading branch information
sephcoster authored Jul 15, 2020
2 parents 1c490e3 + 5743757 commit f6597f7
Show file tree
Hide file tree
Showing 11 changed files with 33 additions and 52 deletions.
2 changes: 1 addition & 1 deletion src/components/Charts/RowChart.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export class RowChart extends React.Component {
return true
}

return o.name ? o.name.indexOf( 'More Information about' ) === -1 : true
return o.name ? o.name.indexOf( 'Visualize trends for' ) === -1 : true
} )

if ( !rows || !rows.length || !total ) {
Expand Down
7 changes: 2 additions & 5 deletions src/components/Trends/ExternalTooltip.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,9 @@ export class ExternalTooltip extends React.Component {
return elements
}

elements.push( <span className="u-left a-btn a-btn__link"
elements.push( <span className="u-left"
id={ 'focus-' + sanitizeHtmlId( value.name ) }
key={ value.name }
onClick={ () => {
this.props.add( value.name, lens )
} }>
key={ value.name }>
{ value.name }
</span> )

Expand Down
11 changes: 6 additions & 5 deletions src/components/Trends/TrendsPanel.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,12 @@ export class TrendsPanel extends React.Component {
<div className="layout-row">
<section className="chart">
<h2 className="area-chart-title">{this._areaChartTitle()}</h2>
<p className="chart-helper-text">A time series graph of the (up
to) five highest volume complaint counts for the selected date
range. Hover on the chart to see the count for each date
interval.
Your filter selections will update what you see on the graph.
<p className="chart-helper-text">A time series graph of the
(up to five) highest volume complaints for the selected date
range. However, you can view all of your selections in the
bar chart, below. Hover on the chart to see the count for
each date interval. Your filter selections will update
what you see on the graph.
</p>
</section>
</div>
Expand Down
5 changes: 0 additions & 5 deletions src/components/__tests__/ExternalTooltip.spec.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,6 @@ describe( 'buttons', () => {
expect( cb ).toHaveBeenCalledWith( 'foo' )
} )

it( 'triggers Focus when the link is clicked', () => {
const prev = target.find( '#focus-bar' )
prev.simulate( 'click' )
expect( cbFocus ).toHaveBeenCalledWith( 'bar', 'Foo' )
} )
} )

describe( 'mapDispatchToProps', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,8 @@ exports[`initial state renders "Other" without crashing 1`] = `
className="color__1"
>
<span
className="u-left a-btn a-btn__link"
className="u-left"
id="focus-foo"
onClick={[Function]}
>
foo
</span>
Expand All @@ -42,9 +41,8 @@ exports[`initial state renders "Other" without crashing 1`] = `
className="color__2"
>
<span
className="u-left a-btn a-btn__link"
className="u-left"
id="focus-bar"
onClick={[Function]}
>
bar
</span>
Expand All @@ -58,9 +56,8 @@ exports[`initial state renders "Other" without crashing 1`] = `
className="color__3"
>
<span
className="u-left a-btn a-btn__link"
className="u-left"
id="focus-allother"
onClick={[Function]}
>
All other
</span>
Expand All @@ -74,9 +71,8 @@ exports[`initial state renders "Other" without crashing 1`] = `
className="color__4"
>
<span
className="u-left a-btn a-btn__link"
className="u-left"
id="focus-eatatjoes"
onClick={[Function]}
>
Eat at Joe's
</span>
Expand Down Expand Up @@ -186,9 +182,8 @@ exports[`initial state renders Company typehead without crashing 1`] = `
className="color__1"
>
<span
className="u-left a-btn a-btn__link"
className="u-left"
id="focus-foo"
onClick={[Function]}
>
foo
</span>
Expand Down Expand Up @@ -216,9 +211,8 @@ exports[`initial state renders Company typehead without crashing 1`] = `
className="color__2"
>
<span
className="u-left a-btn a-btn__link"
className="u-left"
id="focus-bar"
onClick={[Function]}
>
bar
</span>
Expand Down Expand Up @@ -246,9 +240,8 @@ exports[`initial state renders Company typehead without crashing 1`] = `
className="color__3"
>
<span
className="u-left a-btn a-btn__link"
className="u-left"
id="focus-allother"
onClick={[Function]}
>
All other
</span>
Expand Down Expand Up @@ -276,9 +269,8 @@ exports[`initial state renders Company typehead without crashing 1`] = `
className="color__4"
>
<span
className="u-left a-btn a-btn__link"
className="u-left"
id="focus-eatatjoes"
onClick={[Function]}
>
Eat at Joe's
</span>
Expand Down Expand Up @@ -450,9 +442,8 @@ exports[`initial state renders without crashing 1`] = `
className="color__1"
>
<span
className="u-left a-btn a-btn__link"
className="u-left"
id="focus-foo"
onClick={[Function]}
>
foo
</span>
Expand All @@ -466,9 +457,8 @@ exports[`initial state renders without crashing 1`] = `
className="color__2"
>
<span
className="u-left a-btn a-btn__link"
className="u-left"
id="focus-bar"
onClick={[Function]}
>
bar
</span>
Expand All @@ -482,9 +472,8 @@ exports[`initial state renders without crashing 1`] = `
className="color__3"
>
<span
className="u-left a-btn a-btn__link"
className="u-left"
id="focus-allother"
onClick={[Function]}
>
All other
</span>
Expand All @@ -498,9 +487,8 @@ exports[`initial state renders without crashing 1`] = `
className="color__4"
>
<span
className="u-left a-btn a-btn__link"
className="u-left"
id="focus-eatatjoes"
onClick={[Function]}
>
Eat at Joe's
</span>
Expand Down
14 changes: 7 additions & 7 deletions src/components/__tests__/__snapshots__/TrendsPanel.spec.jsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ exports[`component:TrendsPanel Snapshots renders Focus without crashing 1`] = `
<p
className="chart-helper-text"
>
A time series graph of the (up to) five highest volume complaint counts for the selected date range. Hover on the chart to see the count for each date interval. Your filter selections will update what you see on the graph.
A time series graph of the (up to five) highest volume complaints for the selected date range. However, you can view all of your selections in the bar chart, below. Hover on the chart to see the count for each date interval. Your filter selections will update what you see on the graph.
</p>
</section>
</div>
Expand Down Expand Up @@ -734,7 +734,7 @@ exports[`component:TrendsPanel Snapshots renders area without crashing 1`] = `
<p
className="chart-helper-text"
>
A time series graph of the (up to) five highest volume complaint counts for the selected date range. Hover on the chart to see the count for each date interval. Your filter selections will update what you see on the graph.
A time series graph of the (up to five) highest volume complaints for the selected date range. However, you can view all of your selections in the bar chart, below. Hover on the chart to see the count for each date interval. Your filter selections will update what you see on the graph.
</p>
</section>
</div>
Expand Down Expand Up @@ -1411,7 +1411,7 @@ exports[`component:TrendsPanel Snapshots renders date warning without crashing 1
<p
className="chart-helper-text"
>
A time series graph of the (up to) five highest volume complaint counts for the selected date range. Hover on the chart to see the count for each date interval. Your filter selections will update what you see on the graph.
A time series graph of the (up to five) highest volume complaints for the selected date range. However, you can view all of your selections in the bar chart, below. Hover on the chart to see the count for each date interval. Your filter selections will update what you see on the graph.
</p>
</section>
</div>
Expand Down Expand Up @@ -1775,7 +1775,7 @@ exports[`component:TrendsPanel Snapshots renders external Tooltip without crashi
<p
className="chart-helper-text"
>
A time series graph of the (up to) five highest volume complaint counts for the selected date range. Hover on the chart to see the count for each date interval. Your filter selections will update what you see on the graph.
A time series graph of the (up to five) highest volume complaints for the selected date range. However, you can view all of your selections in the bar chart, below. Hover on the chart to see the count for each date interval. Your filter selections will update what you see on the graph.
</p>
</section>
</div>
Expand Down Expand Up @@ -2057,7 +2057,7 @@ exports[`component:TrendsPanel Snapshots renders lineChart Overview without cras
<p
className="chart-helper-text"
>
A time series graph of the (up to) five highest volume complaint counts for the selected date range. Hover on the chart to see the count for each date interval. Your filter selections will update what you see on the graph.
A time series graph of the (up to five) highest volume complaints for the selected date range. However, you can view all of your selections in the bar chart, below. Hover on the chart to see the count for each date interval. Your filter selections will update what you see on the graph.
</p>
</section>
</div>
Expand Down Expand Up @@ -2322,7 +2322,7 @@ exports[`component:TrendsPanel Snapshots renders mobile filters without crashing
<p
className="chart-helper-text"
>
A time series graph of the (up to) five highest volume complaint counts for the selected date range. Hover on the chart to see the count for each date interval. Your filter selections will update what you see on the graph.
A time series graph of the (up to five) highest volume complaints for the selected date range. However, you can view all of your selections in the bar chart, below. Hover on the chart to see the count for each date interval. Your filter selections will update what you see on the graph.
</p>
</section>
</div>
Expand Down Expand Up @@ -2586,7 +2586,7 @@ exports[`component:TrendsPanel Snapshots renders print mode without crashing 1`]
<p
className="chart-helper-text"
>
A time series graph of the (up to) five highest volume complaint counts for the selected date range. Hover on the chart to see the count for each date interval. Your filter selections will update what you see on the graph.
A time series graph of the (up to five) highest volume complaints for the selected date range. However, you can view all of your selections in the bar chart, below. Hover on the chart to see the count for each date interval. Your filter selections will update what you see on the graph.
</p>
</section>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/reducers/__fixtures__/trendsAggsDupes.jsx

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/reducers/__fixtures__/trendsAggsMissingBuckets.jsx

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/reducers/__fixtures__/trendsBackfill.jsx

Large diffs are not rendered by default.

Loading

0 comments on commit f6597f7

Please sign in to comment.