Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop eodrh7 #369

Open
wants to merge 39 commits into
base: develop
Choose a base branch
from
Open

Develop eodrh7 #369

wants to merge 39 commits into from

Conversation

lel99999
Copy link
Contributor

@lel99999 lel99999 commented May 4, 2019

No description provided.

eod_license_server_host:
eod_license_server_cache:

# TODO: you can put all the keys you want to here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to put the actual eod_license _keys in aurora-internal repo behind CPFB enterprise GH

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@tanderegg tanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lel99999 Left a number of comments, please respond if you have any questions. In general, looks like there is a duplicate of all the template files, and you'll need to do a pass to remove commented out code. Thanks!

deploy/Vagrantfile Outdated Show resolved Hide resolved
deploy/deploy_eod7.yml Outdated Show resolved Hide resolved
deploy/deploy_eod7.yml Outdated Show resolved Hide resolved
eod_license_server_host:
eod_license_server_cache:

# TODO: you can put all the keys you want to here
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

deploy/roles/eod7/defaults/main.yaml Outdated Show resolved Hide resolved
deploy/roles/eod7/tasks/main.yaml Outdated Show resolved Hide resolved
deploy/roles/eod7/tasks/main.yaml Show resolved Hide resolved
deploy/roles/eod7/tasks/main.yaml Outdated Show resolved Hide resolved
deploy/roles/eod7/tasks/main.yaml Show resolved Hide resolved
deploy/templates/20-no-show-proxy-dialog.pkla Show resolved Hide resolved
Copy link
Collaborator

@tanderegg tanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lel99999 Almost there, just a few more comments to address, thanks!

deploy/deploy_research_environment.yml Outdated Show resolved Hide resolved
deploy/deploy_research_environment.yml Outdated Show resolved Hide resolved
}
}
# interact return
expect eod
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lel99999 This file should go in the eod7 role right? Also, the binary file above should not be checked in, you'd have to download a copy locally and make sure the Ansible scripts have a variable you can use to point to the right place.

@@ -0,0 +1,20 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lel99999 The .swo file above should not be checked in.

command: systemctl start "{{ item }}"
with_items:
- iptables
- ip6tables
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lel99999 These commands should have a when statement to ensure they are only run when using Vagrant.

deploy/roles/eod7/tasks/main.yaml Show resolved Hide resolved
dest: /etc/X11/xorg.conf
notify:
- restart gdm
# - restart prefdm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lel99999 Remove commented out lines please, thanks!

deploy/roles/eod7/tasks/main.yaml Show resolved Hide resolved
- eod

- name: install iptables-service
command: yum -y install iptables-services
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lel99999 This should also have a when condition.

deploy/roles/iptables/tasks/main.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants