-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop eodrh7 #369
base: develop
Are you sure you want to change the base?
Develop eodrh7 #369
Conversation
eod_license_server_host: | ||
eod_license_server_cache: | ||
|
||
# TODO: you can put all the keys you want to here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to put the actual eod_license _keys in aurora-internal repo behind CPFB enterprise GH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lel99999 Left a number of comments, please respond if you have any questions. In general, looks like there is a duplicate of all the template files, and you'll need to do a pass to remove commented out code. Thanks!
eod_license_server_host: | ||
eod_license_server_cache: | ||
|
||
# TODO: you can put all the keys you want to here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lel99999 Almost there, just a few more comments to address, thanks!
} | ||
} | ||
# interact return | ||
expect eod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lel99999 This file should go in the eod7
role right? Also, the binary file above should not be checked in, you'd have to download a copy locally and make sure the Ansible scripts have a variable you can use to point to the right place.
@@ -0,0 +1,20 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lel99999 The .swo
file above should not be checked in.
command: systemctl start "{{ item }}" | ||
with_items: | ||
- iptables | ||
- ip6tables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lel99999 These commands should have a when
statement to ensure they are only run when using Vagrant.
dest: /etc/X11/xorg.conf | ||
notify: | ||
- restart gdm | ||
# - restart prefdm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lel99999 Remove commented out lines please, thanks!
deploy/roles/eod7/tasks/main.yaml
Outdated
- eod | ||
|
||
- name: install iptables-service | ||
command: yum -y install iptables-services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lel99999 This should also have a when
condition.
Develop eodrh7
updates to templates
…nto develop_eodrh7
…nto develop_eodrh7
Develop eodrh7
adding registered repos to eod deploy
No description provided.