BREAKING CHANGES: Make ProcessLauncher internal

README.md

@@ -11,7 +11,7 @@ A library to support Helm Chart installation in Kubernetes cluster from .NET cod
 ## Sample usage
 
 ```cs
-var chartInstaller = new ChartInstaller(new ProcessLauncher());
+var chartInstaller = new ChartInstaller();
 await using var release = await chartInstaller.Install
 (
     chart: new ChartFromLocalPath("./charts/mysamplechart"),
@@ -50,7 +50,7 @@ Built on top of helm chart provided by https://github.com/microsoft/mssql-docker
 [Test]
 public async Task install_mssql()
 {
-    var chartInstaller = new ChartInstaller(new ProcessLauncher());
+    var chartInstaller = new ChartInstaller();
     await using var release = await chartInstaller.Install
     (
         chart: new ChartFromLocalPath("./charts/mssql"),

src/SmoothSailing.Tests/Examples.cs

@@ -7,10 +7,16 @@ namespace SmoothSailing.Tests;
 
 public class Examples
 {
+    public Examples()
+    {
+        ChartInstaller.DefaultOutputWriter = new NUnitOutputWriter();
+    }
+
     [Test]
     public async Task install_mssql()
     {
-        var chartInstaller = new ChartInstaller(new ProcessLauncher());
+
+        var chartInstaller = new ChartInstaller();
         await using var release = await chartInstaller.Install
         (
             chart: new ChartFromLocalPath("./charts/mssql"),
@@ -27,3 +33,10 @@ public async Task install_mssql()
         Console.WriteLine($"SqlServer available at {localPort}");
     }
 }
+
+class NUnitOutputWriter:IProcessOutputWriter
+{
+    public void Write(string text) => TestContext.Progress.WriteLine(text);
+
+    public void WriteError(string text) => TestContext.Progress.WriteLine(text);
+}

src/SmoothSailing/ChartInstaller.cs

@@ -9,11 +9,13 @@ namespace SmoothSailing;
 
 public class ChartInstaller
 {
+    public static IProcessOutputWriter DefaultOutputWriter { get; set; } = new ConsoleProcessOutputWriter();
+
     private readonly IProcessLauncher _processLauncher;
 
-    public ChartInstaller(IProcessLauncher processLauncher)
+    public ChartInstaller(IProcessOutputWriter? processOutputWriter = null)
     {
-        _processLauncher = processLauncher;
+        _processLauncher = new ProcessLauncher(processOutputWriter ?? DefaultOutputWriter);
     }
 
     /// <summary>

src/SmoothSailing/IProcessLauncher.cs

@@ -3,7 +3,7 @@
 
 namespace SmoothSailing;
 
-public interface IProcessLauncher
+internal interface IProcessLauncher
 {
     IAsyncEnumerable<string> Execute(string command, string parameters, CancellationToken token);
 }

src/SmoothSailing/ProcessLauncher.cs

@@ -9,14 +9,13 @@
 
 namespace SmoothSailing
 {
-    public class ProcessLauncher : IProcessLauncher
+    internal class ProcessLauncher : IProcessLauncher
     {
         private readonly IProcessOutputWriter _processOutputWriter;
-
-        public static IProcessOutputWriter DefaultOutputWriter { get; set; } = new ConsoleProcessOutputWriter();
-        public ProcessLauncher(IProcessOutputWriter? processOutputWriter = null)
+
+        public ProcessLauncher(IProcessOutputWriter processOutputWriter)
         {
-            _processOutputWriter = processOutputWriter ?? DefaultOutputWriter;
+            _processOutputWriter = processOutputWriter;
         }
 
         public async IAsyncEnumerable<string> Execute(string command, string parameters, [EnumeratorCancellation] CancellationToken token)

src/SmoothSailing/ProcessLauncherExtensions.cs

@@ -4,7 +4,7 @@
 
 namespace SmoothSailing;
 
-public static class ProcessLauncherExtensions
+internal static class ProcessLauncherExtensions
 {
     public static async Task<string> ExecuteToEnd(this IProcessLauncher @this, string command, string parameters, CancellationToken token)
     {

src/SmoothSailing/Release.cs

@@ -13,7 +13,7 @@ public class Release : IAsyncDisposable
     private readonly IProcessLauncher _processExecutor;
     private readonly List<(Task, CancellationTokenSource)> _portForwards = new();
 
-    public Release(string deploymentName, IProcessLauncher processExecutor)
+    internal Release(string deploymentName, IProcessLauncher processExecutor)
     {
         DeploymentName = deploymentName;
         _processExecutor = processExecutor;