This repository has been archived by the owner on Aug 17, 2022. It is now read-only.
Update requirements, formatting and move to python3 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, thank you for this very useful script.
Secondly, I apologize for the magnitude of this merge request.
Despite the number of changes, I only applied formatting with black, and updated the script to work with python3 (prints, format strings, ...). I did NOT touch any logic.
I also had to update the requirements to be able to run the script under a python3 environment.
I tried to split it into multiple commits/merge requests, but honnestly, it did not help much.