refactor: country parsing #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamfilos
force-pushed
the
countries-mapping
branch
from
01763bb to
e3e2e7c
Compare
* step 1: take countries from XML, if exist * step 2: if no country added, parse 'value' field and add to 'country' field * step 3: parse final country, through 'COUNTRIES_DEFAULT_MAPPING' to get correct display name * adds pycountry
pamfilos
force-pushed
the
countries-mapping
branch
from
e3e2e7c to
f1b40d0
Compare
Signed-off-by: pamfilos <[email protected]>
pamfilos
force-pushed
the
countries-mapping
branch
from
f1b40d0 to
cb1c602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.