-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile: added airflow constrains #180
Conversation
5436417
to
17fbb9e
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 93.22% 92.62% -0.60%
==========================================
Files 94 105 +11
Lines 4189 4598 +409
==========================================
+ Hits 3905 4259 +354
- Misses 284 339 +55
|
requirements-airflow.txt
Outdated
@@ -1,2 +1,3 @@ | |||
psycopg2==2.9.6 | |||
psycopg2-binary==2.9.6 | |||
connexion==2.14.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed. should be taken care of by the constraints..if it is not installed by the constraints, we should investigate which library needs it, and check if we should install differently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constraints files are requirements files that only control which version of a requirement is installed, not whether it is installed or not. Their syntax and contents is nearly identical to Requirements Files.
https://pip.pypa.io/en/stable/user_guide/#constraints-files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok ..what i mean is:
for postgres, we shouldnt have psycopg2==2.9.6
or psycopg2-binary==2.9.6
, but install it as apache-airflow[celery, postgres]==2.6.0
this way it will install all dependencies that are needed for postgres, and use the constraints for choosing a version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the same way, we should try to see which package tries to install connexion
and why the constraints dont work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the same way, we should try to see which package tries to install connexion
and why the constraints do not work
3417b38
to
dd7eb4c
Compare
No description provided.