Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codeeditor): add diff viewer, types, schema viewer to demo #43

Merged
merged 1 commit into from
May 27, 2024
Merged

feat(codeeditor): add diff viewer, types, schema viewer to demo #43

merged 1 commit into from
May 27, 2024

Conversation

miguelgrc
Copy link
Collaborator

@miguelgrc miguelgrc commented May 23, 2024 •
edited
Loading

Closes #42

  • Exposes CodeEditor and CodeViewer
  • Includes some tweaks to the two fields
  • Adds the CodeDiffViewer component from CAP
  • Mentions these components in the README
  • Adds the CodeViewer to the demo so that users can see the generated schema
  • Adds some types to these components to prevent TS issues when importing them in formule-demo (can be improved)

@miguelgrc miguelgrc force-pushed the expose-code-editor branch from cb0f761 to 6d7f546 Compare May 27, 2024 08:47
@pamfilos pamfilos merged commit 6d7f546 into cern-sis:master May 27, 2024
2 checks passed
@miguelgrc miguelgrc mentioned this pull request May 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamfilos pamfilos pamfilos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose code editor and viewer and add to demo
2 participants
@miguelgrc @pamfilos