Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template support for array item names #25

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

miguelgrc
Copy link
Collaborator

@miguelgrc miguelgrc commented Feb 20, 2024

Closes #24

  • stringify and stringifyTmpl in children item.children.props.uiSchema["ui:options"] have been deprecated in favor of itemsDisplayTitle in uiOptions in the list component. We should remove them completely once @pamfilos takes care of the backend and existing schemas in CAP.
  • Moved codemirror editor to formule and refactored it to work with our new use case and to follow the app styling. I have not yet removed codemirror from CAP, but it could be done anytime and it should work right away (we just need to export the viewer and editor from formule and import them in CAP, to be done in another task)
  • itemsDisplayTitle can be set in a codemirror editor which has jinja syntax highlighting
  • Added useWith: true to squirrelly's render method to be able to use {{asd}} in templates instead of having to prefix it with it. ({{it.asd}})

@miguelgrc miguelgrc merged commit 0be1932 into cern-sis:master Apr 16, 2024
2 checks passed
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to provide a string template for array item names
1 participant