Annual Reports: migration for API class #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErnestaP
force-pushed
the
annual-reports
branch
from
4550162 to
f990391
Compare
ErnestaP
changed the title
drjova
reviewed
Aug 12, 2024
Comment on lines
+58
to
+70
| previous_task = None | ||
| for year in years: | ||
| fetch_task = fetch_categories_report_count.override( | ||
| task_id=f"fetch_report_{year}" | ||
| )(year=year) | ||
| populate_task = populate_categories_report_count.override( | ||
| task_id=f"populate_report_{year}" | ||
| )(entry=fetch_task) | ||
| if previous_task: | ||
| previous_task >> fetch_task | ||
| fetch_task >> populate_task | ||
| previous_task = populate_task | ||
|
|
There was a problem hiding this comment.
Why do we need to chain the tasks?
There was a problem hiding this comment.
we need to run requests to CDS one by one because otherwise, we will break CDS.
My first attempt at this dag implementation was without chaining the tasks, and CDS could not handle it
drjova
reviewed
Aug 12, 2024
| count = Column(Integer, nullable=False) | ||
| year = Column(Integer, nullable=False) | ||
| created_at = Column(DateTime, default=func.now()) | ||
| updated_at = Column(DateTime, default=func.now(), onupdate=func.now()) |
There was a problem hiding this comment.
since we have this it will automatically update the timestamp we don't have to do this
drjova
reviewed
Aug 13, 2024
|
|
||
|
|
||
| def get_endpoint(key, year): | ||
| cds_token = os.environ.get("CDS_TOKEN", "") |
There was a problem hiding this comment.
It's better to use the airflow variables for this kind of things.
drjova
reviewed
Aug 13, 2024
|
|
||
| def get_endpoint(key, year): | ||
| cds_token = os.environ.get("CDS_TOKEN", "") | ||
| if cds_token: |
There was a problem hiding this comment.
the token should be always be there, we can raise and exception if it's missing
drjova
dismissed
their stale review
More changes to get use of airflow variables feature
ErnestaP
force-pushed
the
annual-reports
branch
from
514805a to
53a8d54
Compare
ErnestaP
force-pushed
the
annual-reports
branch
from
24312a2 to
8343b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.