DAGs: migration fro requests lib to http hook #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drjova
requested changes
Jul 29, 2024
| @@ -1,14 +1,14 @@ | |||
| def get_url(key, year): | |||
| url = { | |||
| "publications_total_count": r"http://cdsweb.cern.ch/search?wl=0&ln=en&cc=Published+" | |||
| "publications_total_count": r"search?wl=0&ln=en&cc=Published+" | |||
There was a problem hiding this comment.
these are not urls any more, these are endpoints :)
| endpoint=parameters["endpoint"], | ||
| _retry_args={ | ||
| "stop": stop_after_attempt(3), | ||
| "retry": retry_if_exception_type(Exception), |
There was a problem hiding this comment.
I would retry on request related exceptions, to avoid hiding underlying issues
ErnestaP
force-pushed
the
http-hook
branch
6 times, most recently
from
68f5d55 to
513e819
Compare
drjova
requested changes
Jul 31, 2024
| "type_of_query": key, | ||
| } | ||
|
|
||
| @task |
There was a problem hiding this comment.
don't we need to add executor here?
There was a problem hiding this comment.
yes, we do! Adding it
dags/open_access/open_access.py
Outdated
| url = utils.get_url(query=f"{base_query}") | ||
| data = request_again_if_failed(url=url) | ||
| total = get_total_results_count(data.text) | ||
| query_p = rf"{base_query}+{query[type_of_query]}" |
There was a problem hiding this comment.
what query_p means? we can just have query I think
There was a problem hiding this comment.
sure. query_p - p means that it's a query that goes in p parameter of the endpoint:
return {
"endpoint": rf"search?ln=en&cc={current_collection}&p={query_p}"
+ r"&action_search=Search&op1=a&m1=a&p1=&f1=&c="
+ r"Published+Articles&c=&sf=&so=d&rm=&rg=100&sc=0&of=xm",
"type_of_query": type_of_query,
}
d5d4829 to
e0dfdd9
Compare
drjova
reviewed
Jul 31, 2024
drjova
reviewed
Jul 31, 2024
| @@ -8,10 +6,16 @@ | |||
| LibraryCernPublicationRecords, | |||
| ) | |||
| from common.operators.sqlalchemy_operator import sqlalchemy_task | |||
| from common.utils import get_total_results_count, request_again_if_failed | |||
There was a problem hiding this comment.
can completely remove request_again_if_failed?
drjova
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.