Add timeout to ceph_pool resource #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a few instances, we found ceph_pool hanging. The timeout attribute would allow us to control how long we would like to wait before raising an exception.
|
Hi @Johanni , Error in travis is due to some changes on rubocop. |
| @@ -16,6 +16,9 @@ | |||
| # Optional arguments for pool creation | |||
| attribute :create_options, :kind_of => String | |||
|
|
|||
| # The number of seconds before a timeout occurs during pool creation | |||
| attribute :timeout, :kind_of => Integer, :default => nil, :required => false | |||
There was a problem hiding this comment.
:default => nil, :required => false are optional as it's the default behavior
In a few instances, we found ceph_pool hanging. The timeout attribute would allow us to control how long we would like to wait before raising an exception.
Fix rubocop version in Gemfile
In a few instances, we found ceph_pool hanging. The timeout attribute would allow us to control how long we would like to wait before raising an exception.
|
Took me a while to fix my rebasing, but I think I got it now :) |
|
Do I need to squash commits or is it good as is? |
In a few instances, we found ceph_pool hanging. The timeout attribute would allow us to control how long we would like to wait before raising an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few instances, we found ceph_pool hanging. The timeout attribute
would allow us to control how long we would like to wait before raising
an exception.