fix: blocktower write off logic #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpangelle
force-pushed
the
fix-blocktower-write-off
branch
3 times, most recently
from
77d081c to
b5d3bc2
Compare
jpangelle
force-pushed
the
fix-blocktower-write-off
branch
from
b5d3bc2 to
629aa5c
Compare
|
🚀 Deployed on https://pr-39--goerli-dev-tinlake.netlify.app |
|
🚀 Deployed on https://pr-39--dev-tinlake.netlify.app |
annamehr
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
@jpangelle to summarize the changes
- Double check the amounts for total financed and total repaid
- Add additional line
Total write-offvalue belowTotal repaidin the UI - Write off logic should be
(Total financed + interest) - Total repaid = Total write-off amount - this should apply to all detail pages of assets that have write-offs
|
Now the percent write off works and it shows repaid which is good. What is missing is we can not see the value written off. It should be approx 130k. And the amount repaid seems off. In the past when an asset has an amount written off it shows it in the outstanding section. In order for this to correct it should be listed in the outstanding or be given its own data row in risk section where it shows write off value. Given we don't intend to make real changes tinlake the first option is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes issues with Blocktower pool write off logic.
Approvals
Screenshots
Impact
Asset list and asset page