Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tests and Bugfixes #32

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix: Tests and Bugfixes #32

merged 2 commits into from
Dec 13, 2024

Conversation

onnovisser
Copy link
Collaborator

Description

Fixes the timeout on the activeNetworks query to only err when the first value is too late.
Removes caching for queries with no keys and updates tests.
Adds tests for deploying vaults and tranches

#

@onnovisser onnovisser added bug Something isn't working alpha Include in alpha release labels Dec 13, 2024
@onnovisser onnovisser requested a review from kattylucy December 13, 2024 10:16
Copy link

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Tests and Bugfixes". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link

PR must have ONLY one of the following labels: major, minor, patch, no-release, alpha.
Check the logs for more details: https://github.com/centrifuge/sdk/actions/runs/12313768794

@onnovisser onnovisser removed the bug Something isn't working label Dec 13, 2024
@onnovisser onnovisser changed the title Tests and Bugfixes fix: Tests and Bugfixes Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.59%. Comparing base (c9cb0a2) to head (45882d9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   86.46%   88.59%   +2.12%     
==========================================
  Files          24       24              
  Lines        3029     3033       +4     
  Branches      253      266      +13     
==========================================
+ Hits         2619     2687      +68     
+ Misses        404      339      -65     
- Partials        6        7       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@onnovisser onnovisser merged commit 6ae2d36 into main Dec 13, 2024
10 of 12 checks passed
@onnovisser onnovisser deleted the fixes-and-tests branch December 13, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Include in alpha release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants